This looks fine in general: Reviewed-by: Christoph Hellwig <hch at lst.de> But: this now introduce struct inode to libxfs code, what's your plan to deal with that in xfsprogs?