[PATCH] xfs: kill __uint*_t and __int*_t

Dave Chinner david at fromorbit.com
Tue Aug 23 17:35:00 CDT 2016


On Tue, Aug 09, 2016 at 01:33:32AM -0700, Christoph Hellwig wrote:
> On Sun, Aug 07, 2016 at 07:38:35PM +0200, Felix Janda wrote:
> > Replace them by the more widely used uint*_t and int*_t.
> > 
> > Signed-off-by: Felix Janda <felix.janda at posteo.de>
> > ---
> > This patch is essentially a global
> > 'sed -i "s/__\(u*\)int\([0-9]*\)_t/\1int\2_t/"'. The only other changes
> > are whitespace changes and removing the now unecessary type definitions.
> > 
> > Running 'sed "s/^.//"' on the patch might be useful for checking that
> > I didn't mess up the indentation.
> 
> If everyone is fine using (u)int*_t over s*/u* this looks good.  I'd
> have a slight preference for s*/u* as in the rest of the kernel, but
> either way getting rid of our crazy __ types is a good thing.

Don't really care that much. I'd prefer (marginally) to go with the
(u)int*_t types as userspace then doesn't need a set of typedefs in
the platform headers to support the kernel specific types in libxfs
code....

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list