> +extern int xfs_assert_largefile[sizeof(off_t)-8]; Please add a comment on why we have this declaration, otherwise this looks fine to me: Reviewed-by: Christoph Hellwig <hch at lst.de>