[PATCH] xfs_metadump: don't warn about unobfuscated log with -o

Eric Sandeen sandeen at sandeen.net
Thu Aug 4 10:51:12 CDT 2016


It makes no sense to warn about un-obfuscated logs
when we asked xfs_metadump to not obfuscate metadata:

# xfs_metadump -o /dev/loop2 bad.metadump
xfs_metadump: Filesystem log is dirty; image will contain unobfuscated metadata in log.

Signed-off-by: Eric Sandeen <sandeen at redhat.com>
---

diff --git a/db/metadump.c b/db/metadump.c
index d7ff6e5..01a51c4 100644
--- a/db/metadump.c
+++ b/db/metadump.c
@@ -2575,12 +2575,14 @@ copy_log(void)
 		break;
 	case 1:
 		/* keep the dirty log */
-		print_warning(
+		if (obfuscate)
+			print_warning(
 _("Filesystem log is dirty; image will contain unobfuscated metadata in log."));
 		break;
 	case -1:
 		/* log detection error */
-		print_warning(
+		if (obfuscate)
+			print_warning(
 _("Could not discern log; image will contain unobfuscated metadata in log."));
 		break;
 	}



More information about the xfs mailing list