[PATCH xfsprogs 2/2] linux.h: Define xfs_off_t as int64_t

[Dave Chinner]

On Mon, Aug 01, 2016 at 08:54:10AM +0200, Felix Janda wrote:
> Christoph Hellwig wrote:
> > On Sat, Jul 30, 2016 at 03:37:37PM +0200, Felix Janda wrote:
> > > int64_t is guaranteed to have the correct size and signedness and is
> > > always avaible because linux.h has a <inttypes.h> include.
> > > 
> > > Fixes compilation error "unkown type name 'off64_t'" on linux when the
> > > public header <xfs.h> is included without _LARGEFILE64_SOURCE or
> > > _GNU_SOURCE defined. This bug was introduced in commit
> > > cb898f157f8410a03cf5f3400baa1df9e5eecd33.
> > 
> > I would much prefer to just define _LARGEFILE64_SOURCE in linux.h..
> 
> Thanks for the suggestion, but that does not work if the system header
> defining (or not) off64_t is included before the xfs headers.

Which, to me, is a build bug in whatever code is including the xfs
headers.  Isn't it the responsibility of the build environment to
ensure the dependencies of the libraries being used are correctly
met?

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com