[PATCH 02/19] mkfs: sanitise ftype parameter values.
Jan Tulak
jtulak at redhat.com
Thu Apr 21 04:39:36 CDT 2016
From: Dave Chinner <dchinner at redhat.com>
Because passing "-n ftype=2" should fail.
Signed-off-by: Dave Chinner <dchinner at redhat.com>
Signed-off-by: Jan Tulak <jtulak at redhat.com>
---
UPDATE:
* Remove a check for crc enabled with ftype - there is another one later on.
As it was in the ftype handling, it failed if -m crc=0 was after ftype.
---
mkfs/xfs_mkfs.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 5527b87..4be14da 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -1597,7 +1597,10 @@ main(
reqval('n', nopts, N_FTYPE);
if (nftype)
respec('n', nopts, N_FTYPE);
- dirftype = atoi(value);
+ c = atoi(value);
+ if (c < 0 || c > 1)
+ illegal(value, "n ftype");
+ dirftype = c;
nftype = 1;
break;
default:
--
2.5.0
More information about the xfs
mailing list