[PATCH 11/19] mkfs: table based parsing for converted parameters
Eric Sandeen
sandeen at sandeen.net
Thu Apr 7 14:08:54 CDT 2016
On 3/24/16 6:15 AM, jtulak at redhat.com wrote:
> From: Dave Chinner <dchinner at redhat.com>
>
> CHANGE:
> o Change getnum_checked type to long long to prevent int overflow
> o Add description of new members in opt_params struct.
> o L_SU maxval was a wrong number, fix it
>
> All the parameters that can be passed as block or sector sizes need
> to be passed the block and sector sizes that they should be using
> for conversion. For parameter parsing, it is always the same two
> variables, so to make things easy just declare them as global
> variables so we can avoid needing to pass them to getnum_checked().
>
> We also need to mark these parameters are requiring conversion so
> that we don't need to pass this information manually to
> getnum_checked(). Further, some of these options are required to
> have a power of 2 value, so add optional checking for that as well.
>
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
> Signed-off-by: Jan Tulak <jtulak at redhat.com>
Reviewed-by: Eric Sandeen <sandeen at redhat.com>
More information about the xfs
mailing list