[PATCH 1/3] xfs: create global stats and stats_clear in sysfs

Eric Sandeen sandeen at sandeen.net
Fri Sep 4 15:13:49 CDT 2015


On 9/4/15 7:55 AM, Bill O'Donnell wrote:
> Currently, xfs global stats are in procfs. This patch introduces
> (replicates) the global stats in sysfs. Additionally a stats_clear file
> is introduced in sysfs.
> 
> Signed-off-by: Bill O'Donnell <billodo at redhat.com>


> +STATIC ssize_t
> +xfs_stats_store(
> +	struct kobject          *kobject,
> +	struct attribute        *attr,
> +	const char              *buf,
> +	size_t                  count)

still have some spaces after the types, before the vars...

Otherwise, this looks good to me; it's not the only place we have
missing tabs... *shrug* you could resend, or maybe Dave's willing
to fix up on commit.

Reviewed-by: Eric Sandeen <sandeen at redhat.com>

Thanks,
-Eric



More information about the xfs mailing list