[PATCH] xfs_io: implement 'inode' command V3

Carlos Maiolino cmaiolino at redhat.com
Fri Oct 23 04:29:46 CDT 2015


Thanks for the review Brian, I'll walk over it and fix the points you mentioned.
> 
> 
> I still don't really get why we have separate -l and -s options here. It
> seems to me that the behavior of -l already gives us the information
> that -s does. Even if that's not obvious enough, the -l command could
> just print out both. For example:
> 
>       "Largest inode: 1234 (32-bit)"

I agree with you here, but, I'll let Dave answer this question, maybe he had 
some another idea for it that I'm not aware of. 

Cheers.
-- 
Carlos



More information about the xfs mailing list