[PATCH v2 0/5] xfs: SGI ACL Fixes

Dave Chinner david at fromorbit.com
Sun Nov 1 20:53:52 CST 2015


On Fri, Oct 30, 2015 at 04:05:03PM +0100, Andreas Gruenbacher wrote:
> Here is a reworked patch queue that also handles setting SGI_ACL_{FILE,DEFAULT}
> via XFS_IOC_ATTRMULTI_BY_HANDLE.  Please review.
> 
> Thanks,
> Andreas
> 
> Andreas Gruenbacher (5):
>   xfs: Validate the length of on-disk ACLs
>   xfs: Plug memory leak in xfs_attrmulti_attr_set

Ok, I've taken these two patches for the upcoming merge window as
they fix bugs, but I've taken Brian's cached ACL invalidation patch
instead of these:

>   xfs: SGI ACLs: Fix caching and mode setting
>   xfs: Add namespace parameter to the xfs kuid/kgid <=> uid/gid wrappers
>   xfs: SGI ACLs: Map uid/gid namespaces

I'm not yet convinced that these patches are the right way to solve
the given issue as they may interact badly with xfsdump/restore.
However, I do want the kernel code to behave correctly after
xfs_restore runs and Brian's change is enough to do this. If
we do decide that we need to make the above changes to the posix
acl code, it's easy enough to replace this invalidation code.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list