[PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent

Joe Perches joe at perches.com
Tue Mar 3 14:39:42 CST 2015


On Tue, 2015-03-03 at 20:21 +0100, Fabian Frederick wrote:
> new_parent is only used in 0/1 context.
[]
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
[]
> @@ -2860,7 +2860,7 @@ xfs_rename(
>  {
>  	xfs_trans_t	*tp = NULL;
>  	xfs_mount_t	*mp = src_dp->i_mount;
> -	int		new_parent;		/* moving to a new dir */
> +	bool		new_parent;		/* moving to a new dir */
>  	int		src_is_directory;	/* src_name is a directory */

Could convert src_is_directory to bool too.




More information about the xfs mailing list