[PATCH] xfs: don't release NULL pip in xfs_filestream_lookup_ag()
Eric Sandeen
sandeen at redhat.com
Tue Mar 3 14:14:57 CST 2015
If xfs_filestream_get_parent() fails, we have a null pip,
goto out, and attempt to IRELE(NULL). This causes a null
pointer dereference and BUG().
Fix this by testing for pip before trying to release it.
Reported-by: Adrien Nader <adrien at notk.org>
Signed-off-by: Eric Sandeen <sandeen at redhat.com>
---
diff --git a/fs/xfs/xfs_filestream.c b/fs/xfs/xfs_filestream.c
index a2e86e8..fb09a63 100644
--- a/fs/xfs/xfs_filestream.c
+++ b/fs/xfs/xfs_filestream.c
@@ -348,7 +348,8 @@ xfs_filestream_lookup_ag(
if (xfs_filestream_pick_ag(pip, startag, &ag, 0, 0))
ag = NULLAGNUMBER;
out:
- IRELE(pip);
+ if (pip)
+ IRELE(pip);
return ag;
}
More information about the xfs
mailing list