[PATCH 2/4] libxfs: simplify xfs_trans_free_items
Christoph Hellwig
hch at lst.de
Wed Jun 17 05:52:59 CDT 2015
Remove the unused flags parameter and mark the function as static.
Signed-off-by: Christoph Hellwig <hch at lst.de>
---
libxfs/libxfs_priv.h | 1 -
libxfs/trans.c | 11 ++++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/libxfs/libxfs_priv.h b/libxfs/libxfs_priv.h
index 63da624..5819efa 100644
--- a/libxfs/libxfs_priv.h
+++ b/libxfs/libxfs_priv.h
@@ -423,7 +423,6 @@ int xfs_trans_roll(struct xfs_trans **, struct xfs_inode *);
/* xfs_trans_item.c */
void xfs_trans_add_item(struct xfs_trans *, struct xfs_log_item *);
void xfs_trans_del_item(struct xfs_log_item *);
-void xfs_trans_free_items(struct xfs_trans *, int);
/* xfs_inode_item.c */
void xfs_inode_item_init(struct xfs_inode *, struct xfs_mount *);
diff --git a/libxfs/trans.c b/libxfs/trans.c
index 9a44af4..866c379 100644
--- a/libxfs/trans.c
+++ b/libxfs/trans.c
@@ -30,6 +30,8 @@
#include "xfs_trans.h"
#include "xfs_sb.h"
+static void xfs_trans_free_items(struct xfs_trans *tp);
+
/*
* Simple transaction interface
*/
@@ -205,7 +207,7 @@ libxfs_trans_cancel(
xfs_trans_t *otp = tp;
#endif
if (tp != NULL) {
- xfs_trans_free_items(tp, flags);
+ xfs_trans_free_items(tp);
free(tp);
tp = NULL;
}
@@ -778,10 +780,9 @@ inode_item_unlock(
* Unlock all of the items of a transaction and free all the descriptors
* of that transaction.
*/
-void
+static void
xfs_trans_free_items(
- struct xfs_trans *tp,
- int flags)
+ struct xfs_trans *tp)
{
struct xfs_log_item_desc *lidp, *next;
@@ -818,7 +819,7 @@ libxfs_trans_commit(
#ifdef XACT_DEBUG
fprintf(stderr, "committed clean transaction %p\n", tp);
#endif
- xfs_trans_free_items(tp, flags);
+ xfs_trans_free_items(tp);
free(tp);
tp = NULL;
return 0;
--
1.9.1
More information about the xfs
mailing list