[PATCH 0/2] xfsprogs/repair: secondary sb scan cleanups

Brian Foster bfoster at redhat.com
Tue Jan 13 14:08:11 CST 2015


Hi all,

Here are a couple patches to clean up the secondary sb scanning in phase
1 of xfs_repair. Patch 1 is a fix for a bug encountered by a user with a
corrupted fs/array that lead to scattered sb corruption:

http://oss.sgi.com/archives/xfs/2015-01/msg00113.html

Patch 2 is a larger cleanup of the affected sb scan function after
reading through the code and not being able to grok the need for some of
the extra complexity therein. I don't think it should affect behavior
much, but thoughts appreciated.

Brian

Brian Foster (2):
  repair: fix unnecessary secondary scan if only last sb is corrupt
  repair: remove unused strided secondary sb scan logic

 repair/globals.h |  2 --
 repair/sb.c      | 67 +++++++++++++++++++-------------------------------------
 2 files changed, 22 insertions(+), 47 deletions(-)

-- 
1.8.3.1



More information about the xfs mailing list