[PATCH v2 3/4] xfsprogs: mkfs: fix unintentional integer overflow
Christoph Hellwig
hch at infradead.org
Sun Dec 20 09:36:49 CST 2015
> +++ b/mkfs/xfs_mkfs.c
> @@ -2022,7 +2022,7 @@ _("warning: sparse inodes not supported without CRC support, disabled.\n"));
> * and the underlying volume is striped, then set rtextblocks
> * to the stripe width.
> */
> - int rswidth;
> + __uint64_t rswidth;
> __uint64_t rtextbytes;
This looks odd. We initiallize assigned ft.rtswidth (which is an int)
or 0 to it. I think you want a separate variable for the result of
the DTOBT(rswidth) statement to make this clear.
More information about the xfs
mailing list