[PATCH 11/11] xfsprogs: xfs_repair: fix possible null pointer dereference in mark_standalone_inodes

Dave Chinner david at fromorbit.com
Thu Dec 3 00:34:08 CST 2015


On Wed, Dec 02, 2015 at 04:49:27PM +0530, Vivek Trivedi wrote:
> Fix possible null pointer dereference in mark_standalone_inodes by
> rearranging and adding ASSERT for null irec.
> Reported by coverity.

Makes no difference if we assert fail or segv, it's the same result.
Hence I don't see any point in adding asserts like this - we don't
do it for the kernel code because it's just noise and it's
essentially the same here...

Just tell coverity to ignore this warnings...

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list