[PATCH 0/2] xfsdump: fix problems in cb_add_inogrp

Rich Johnston rjohnston at sgi.com
Wed Aug 26 09:33:54 CDT 2015


On 08/21/2015 03:11 PM, Eric Sandeen wrote:
> On 8/21/15 3:08 PM, Rich Johnston wrote:
>> On 08/21/2015 10:47 AM, Eric Sandeen wrote:
>>> Hi -
>>>
>>> Are there any testcases for these?  xfsdump is alien code, I swear;
>>> I'm not quite sure offhand how to tickle any of these bugs.
>>>
>>> Thanks,
>>> -Eric
>>>
>>
>> Hey Eric,
>>
>> Many thanks for taking the time to review these patches.
>> I take a look at all your responses and get a V2 out early next week.
>
> Sounds good.  If I was off track about the need for the extra 64-bit vars,
> just educate me.  ;)
>
> -Eric
>
Ok you convinced me, there is no need for patch 1 and patch 2 can be
solved by removing the local variable oldsize.

A new patch has been submitted.
[PATCH] xfsdump: prevent segfault in cb_add_inogrp



More information about the xfs mailing list