[PATCH v4 09/11] xfsprogs: Add mntent.h check into autoconf

Jan Tulak jtulak at redhat.com
Mon Aug 17 10:15:12 CDT 2015


On Mon, Aug 17, 2015 at 5:04 PM, Christoph Hellwig <hch at infradead.org>
wrote:

> This looks mostly fine.  I think you could just add the
> AC_CHECK_HEADERS directly to configure.ac, but otherwise it's exactly
> what I though.
>

In configure.ac, there are no direct checks for headers, just calls of all
the various
AC_HAVE_*. I'm not sure it is a good idea to mix now. Unless you think that
all
the functions should be moved into configure.ac from the m4/ directory.



> Can you please resend all your pending patches in a single series,
> and move the UPDATES: lines and other internal changelogs to the
> cover letter instead of the patch descriptions?
>
> Thanks for doing this work!
>

Sure, I'll send it again as a whole. And np. :-)

-- 
Jan Tulak
jtulak at redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20150817/90a531e1/attachment.html>


More information about the xfs mailing list