[PATCH 01/11] xfs: disentagle EFI release from the extent count

Christoph Hellwig hch at infradead.org
Sun Aug 9 02:36:41 CDT 2015


On Thu, Aug 06, 2015 at 01:44:22PM -0400, Brian Foster wrote:

-       __xfs_efi_release(efip);
+	xfs_efi_release(efip);

Can you explain in the changelog why this is safe?


> -xfs_efi_release(xfs_efi_log_item_t	*efip,
> -		uint			nextents)
> +xfs_efi_release(struct xfs_efi_log_item	*efip)

Can you use normal XFS function formatting here? e.g.

xfs_efi_release(
	struct xfs_efi_log_item		*efip)


As a follow on we should be able to remove atomic_inc_return and
replace it with a local iterator in xfs_bmap_finish().



More information about the xfs mailing list