[PATCH] mkfs.xfs: fix ftype-vs-crc option combination testing

[Eric Sandeen]

On 8/7/15 4:37 AM, Brian Foster wrote:
> On Thu, Aug 06, 2015 at 10:18:50PM -0700, Eric Sandeen wrote:
>> mkfs.xfs got weird along the way; today it has different outcomes
>> depending on the order of option specification:
>>
>> $ mkfs/mkfs.xfs -n ftype=1 -m crc=0 -dfile,name=fsfile,size=16g
>> cannot specify both crc and ftype
>> $ mkfs/mkfs.xfs -m crc=0 -n ftype=1 -dfile,name=fsfile,size=16g
>> <succeeds>
>>
>> Somehow the tests got written as being constrained on what options
>> are specified - and in what order! - vs actually testing for
>> incompatible feature sets.
>>
> 
> IIRC, I think this is one of the core problems the big mkfs option
> parsing rework that Jan is working on is supposed to fix.

Yeah, I think so - Jan, if this gets in your way, let us know - 
I didn't mean to make your life difficult by fixing little
things while you work.  :)

-Eric