[PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing

Jan Tulak jtulak at redhat.com
Wed Aug 5 04:49:37 CDT 2015



----- Original Message -----
> From: "Dave Chinner" <david at fromorbit.com>
> To: "Jan Tulak" <jtulak at redhat.com>
> Cc: "Christoph Hellwig" <hch at infradead.org>, xfs at oss.sgi.com
> Sent: Wednesday, August 5, 2015 1:00:00 AM
> Subject: Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was	missing
> 
> On Tue, Aug 04, 2015 at 10:19:40AM -0400, Jan Tulak wrote:
> > ----- Original Message -----
> > > From: "Christoph Hellwig" <hch at infradead.org>
> > > 
> > > Needs to be fixed to avoid > 80 char lines.
> > > 
> > 
> > I don't see any >80 char line in this patch. O_o
> > The longest line is 73 in the code and 62 in commit
> > message. Though... maybe it can be a tab width issue?
> > I use four spaces for a tab...
> 
> 8 spaces to a tab, please. Same coding style rules as for writing
> kernel code. ;)

All right, fixed patch sent. :-)

Cheers,
Jan

-- 
Jan Tulak
jtulak at redhat.com



More information about the xfs mailing list