[PATCH] xfs: compat_xfs_bstat does not have forkoff

Christoph Hellwig hch at infradead.org
Mon Sep 29 05:43:18 CDT 2014


On Mon, Sep 29, 2014 at 11:41:26AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> struct compat_xfs_bstat is missing the di_forkoff field and so does
> not fully translate the structure correctly. Fix it.
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
> ---
>  fs/xfs/xfs_ioctl32.c | 2 ++
>  fs/xfs/xfs_ioctl32.h | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>

Any chance to get an xfstests test that verifies the forkoff value?
Even if it would only reproduce this bug when running 32-bit userspace
on a 64-bit kernel it would be useful I think.



More information about the xfs mailing list