[PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable()

Christoph Hellwig hch at infradead.org
Thu Sep 25 11:17:56 CDT 2014


> index d36bdbc..9073895 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -607,7 +607,7 @@ xfs_mount_reset_sbqflags(
>  	 * If the fs is readonly, let the incore superblock run
>  	 * with quotas off but don't flush the update out to disk
>  	 */
> -	if (mp->m_flags & XFS_MOUNT_RDONLY)
> +	if (!xfs_fs_writable(mp, SB_UNFROZEN))

This adds a new caller of xfs_fs_writable, which isn't mentioned in the
changelog.

> +	/*
> +	 * We can be called during the fs freeze process, and we need to be
> +	 * able to write the superblock in that case.
> +	 */
> +	if (!xfs_fs_writable(mp, SB_FREEZE_FS))
>  		return 0;

And this already changes the checked freeze level, also not mentioned.



More information about the xfs mailing list