[PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype
Eric Sandeen
sandeen at redhat.com
Sun Sep 7 11:41:04 CDT 2014
xfs_dir3_dirent_get_ftype() gets the file type
off disk, but ASSERTs if it's invalid:
ASSERT(type < XFS_DIR3_FT_MAX);
This might be cut & paste from
xfs_dir3_dirent_put_ftype which should be checking
that it's not been passed bad values, but we
shouldn't ASSERT on bad values read from disk.
Signed-off-by: Eric Sandeen <sandeen at redhat.com>
---
include/xfs_da_format.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/include/xfs_da_format.h b/include/xfs_da_format.h
index 89a1a21..11f1420 100644
--- a/include/xfs_da_format.h
+++ b/include/xfs_da_format.h
@@ -561,7 +561,6 @@ xfs_dir3_dirent_get_ftype(
if (xfs_sb_version_hasftype(&mp->m_sb)) {
__uint8_t type = dep->name[dep->namelen];
- ASSERT(type < XFS_DIR3_FT_MAX);
if (type < XFS_DIR3_FT_MAX)
return type;
--
1.7.1
More information about the xfs
mailing list