[PATCH 1/2] xfs: don't send null bp to xfs_trans_brelse()

Christoph Hellwig hch at infradead.org
Wed Oct 1 10:55:29 CDT 2014


On Wed, Oct 01, 2014 at 10:22:19AM -0500, Eric Sandeen wrote:
> In this case, if bp is NULL, error is set, and we send a
> NULL bp to xfs_trans_brelse, which will try to dereference it.
> 
> Test whether we actually have a buffer before we try to
> free it.
> 
> Coverity spotted this.
> 
> Signed-off-by: Eric Sandeen <sandeen at redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list