[PATCH 1/4] fs: split update_time() into update_time() and write_time()

Theodore Ts'o tytso at mit.edu
Fri Nov 21 15:42:45 CST 2014


Out of curiosity, why does btrfs_update_time() need to call
btrfs_root_readonly()?  Why can't it just depend on the
__mnt_want_write() call in touch_atime()?

Surely if there are times when it's not OK to write into a btrfs file
system and mnt_is_readonly() returns false, the VFS is going to get
very confused abyway.

If the btrfs_update_time() is not necessary, then we could drop
btrfs_update_time() and update_time() from the inode operations
entirely, and depend on the VFS-level code in update_time().

	      	     	    	      	   - Ted



More information about the xfs mailing list