[PATCH 4/9] xfsdump: remove pointless if (dirty);

Mark Tinguely tinguely at sgi.com
Thu Nov 13 11:35:18 CST 2014


On 11/12/14 12:57, Eric Sandeen wrote:
> "dirty" seems to be a remnant of unfinished code; other bits of
> it are there but commented out, so comment out "if (dirty);" as
> well, which is a no-op if statement which can't be true.
>
> Signed-off-by: Eric Sandeen<sandeen at redhat.com>
> ---
>   inventory/inv_stobj.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/inventory/inv_stobj.c b/inventory/inv_stobj.c
> index becac17..84b15d9 100644
> --- a/inventory/inv_stobj.c
> +++ b/inventory/inv_stobj.c
> @@ -976,7 +976,9 @@ stobj_delete_mobj(int fd,
>
>   		}
>   		free ( mfiles );
> +/*
>   		if ( dirty );
> +*/
>   	}
>
>   	free ( strms );

Why not remove all the references to dirty in the function?
Like you said, it doesn't do anything.

--Mark.



More information about the xfs mailing list