[PATCH] mm/vmscan: Do not block forever at shrink_inactive_list().
Tetsuo Handa
penguin-kernel at I-love.SAKURA.ne.jp
Mon May 19 22:54:29 CDT 2014
Dave Chinner wrote:
> So, XFS should be passing kswapd context to the workqueue allocation
> context. The patch below does this.
>
> Tetsuo-san, when it comes to problems involving XFS, you should
> really CC xfs at oss.sgi.com because very few people really know how
> XFS works and even fewer still know how it is supposed to interact
> with memory reclaim....
Thank you for the patch, but ...
#define PF_KSWAPD 0x00040000 /* I am kswapd */
static inline int current_is_kswapd(void)
{
return current->flags & PF_KSWAPD;
}
I think ((char) (current->flags & 0x00040000)) == 0.
Your patch wants
-args->kswapd = current_is_kswapd();
+args->kswapd = (current_is_kswapd() != 0);
More information about the xfs
mailing list