[PATCH 4/9] xfs: correct error sign on COLLAPSE_RANGE errors

[Jeff Liu]

On 05/13 2014 16:56 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
> ---
>  fs/xfs/xfs_file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 37f98c6..830c1c9 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -837,7 +837,7 @@ xfs_file_fallocate(
>  		unsigned blksize_mask = (1 << inode->i_blkbits) - 1;
>  
>  		if (offset & blksize_mask || len & blksize_mask) {
> -			error = -EINVAL;
> +			error = EINVAL;
>  			goto out_unlock;
>  		}
>  
> @@ -846,7 +846,7 @@ xfs_file_fallocate(
>  		 * in which case it is effectively a truncate operation
>  		 */
>  		if (offset + len >= i_size_read(inode)) {
> -			error = -EINVAL;
> +			error = EINVAL;
>  			goto out_unlock;
>  		}
>  
> 

Reviewed-by: Jie Liu <jeff.liu at oracle.com>


Cheers,
-Jeff