[PATCH 4/5] xfs: don't need dirv2 checks anymore

Dave Chinner david at fromorbit.com
Tue May 6 03:45:05 CDT 2014


On Tue, May 06, 2014 at 01:16:52AM -0700, Christoph Hellwig wrote:
> > -	ASSERT(xfs_sb_version_hasdirv2(&mp->m_sb));
> > +	ASSERT(mp->m_sb.sb_versionnum & XFS_SB_VERSION_DIRV2BIT);
> 
> How is this going to work for v5 filesystems?  Probably better to just
> kill the assert..

mkfs still sets the sb_features bitmask for all the supported v4
features it uses by default on v5 superblocks. There are some
feature bits in the v4 mask that are optional for v5 superblocks,
too (e.g. case insensitivity, sunit/swidth alignment), so we won't
ever stop setting the XFS_SB_VERSION_DIRV2BIT on v5 superblocks...

> Otherwise looks good,
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>

Thanks!

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list