[PATCH 5/5] xfs: remove shared supberlock feature checking
Jeff Liu
jeff.liu at oracle.com
Tue May 6 02:48:43 CDT 2014
On 05/06 2014 11:55 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
>
> We reject any filesystem that is mounted with this feature bit set,
> so we don't need to check for it anywhere else. Remove the function
> for checking if the feature bit is set and any code that uses it.
>
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
> ---
> fs/xfs/xfs_fsops.c | 2 --
> fs/xfs/xfs_sb.c | 3 ++-
> fs/xfs/xfs_sb.h | 17 ++++-------------
> 3 files changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
> index b099799..97886a7 100644
> --- a/fs/xfs/xfs_fsops.c
> +++ b/fs/xfs/xfs_fsops.c
> @@ -84,8 +84,6 @@ xfs_fs_geometry(
> XFS_FSOP_GEOM_FLAGS_IALIGN : 0) |
> (xfs_sb_version_hasdalign(&mp->m_sb) ?
> XFS_FSOP_GEOM_FLAGS_DALIGN : 0) |
> - (xfs_sb_version_hasshared(&mp->m_sb) ?
> - XFS_FSOP_GEOM_FLAGS_SHARED : 0) |
Just a trivial comments, now the XFS_FSOP_GEOM_FLAGS_SHARED is useless, so
we can remove it from fs/xfs/xfs.h.
Otherwise, looks good to me.
Reviewed-by: Jie Liu <jeff.liu at oracle.com>
Cheers,
-Jeff
More information about the xfs
mailing list