[patch] xfs: extra semi-colon breaks a condition

Eric Sandeen sandeen at sandeen.net
Fri Mar 28 20:56:04 CDT 2014


On 3/28/14, 3:03 AM, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
> 
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')

that's terrifying.

Reviewed-by: Eric Sandeen <sandeen at redhat.com>

> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
>  			if (type == XFS_IO_UNWRITTEN)
>  				return true;
>  		} else if (buffer_delay(bh)) {
> -			if (type == XFS_IO_DELALLOC);
> +			if (type == XFS_IO_DELALLOC)
>  				return true;
>  		} else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> -			if (type == XFS_IO_OVERWRITE);
> +			if (type == XFS_IO_OVERWRITE)
>  				return true;
>  		}
>  
> 
> _______________________________________________
> xfs mailing list
> xfs at oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 



More information about the xfs mailing list