[PATCH] xfs_quota: avoid segfault when report -h on non-existent path

Eryu Guan eguan at redhat.com
Tue Mar 18 11:39:06 CDT 2014


Command xfs_quota -xc "report -h" /nosuchdir would get segfault, fix
that by checking fs_path first before dereferencing it.

Cc: Eric Sandeen <esandeen at redhat.com>
Signed-off-by: Eryu Guan <eguan at redhat.com>
---
 quota/report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/quota/report.c b/quota/report.c
index 70894a2..d486524 100644
--- a/quota/report.c
+++ b/quota/report.c
@@ -624,7 +624,7 @@ report_f(
 		if (flags & ALL_MOUNTS_FLAG)
 			report_any_type(fp, form, type, NULL,
 					lower, upper, flags);
-		else if (fs_path->fs_flags & FS_MOUNT_POINT)
+		else if (fs_path && fs_path->fs_flags & FS_MOUNT_POINT)
 			report_any_type(fp, form, type, fs_path->fs_dir,
 					lower, upper, flags);
 	} else while (argc > optind) {
-- 
1.8.5.3



More information about the xfs mailing list