[PATCH v2 6/8] fsstress: translate flags in fiemap_f

Christoph Hellwig hch at infradead.org
Thu Mar 6 11:48:13 CST 2014


> +#ifdef HAVE_LINUX_FIEMAP_H
> +struct print_flags fiemap_flags[] = {
> +	{ FIEMAP_FLAG_SYNC, "SYNC"},
> +	{ FIEMAP_FLAG_XATTR, "XATTR"},
> +	{ -1, NULL}
> +};

Can be static.

> +
> +#define translate_fiemap_flags(mode)	\
> +	({translate_flags(mode, "|", fiemap_flags);})
> +#endif

Any reason to not have these two inside fiemap_f?

Otherwise:

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list