[PATCH 2/2] xfs: flush both inodes in xfs_swap_extents

Dave Chinner david at fromorbit.com
Thu Jul 31 18:02:12 CDT 2014


On Thu, Jul 31, 2014 at 10:16:02AM -0700, Christoph Hellwig wrote:
> >  int
> > +xfs_swap_extent_flush(
> > +	struct xfs_inode	*ip)
> > +{
> > +	int	error;
> 
> nipick:  shouldn't the arguments and local variables align to the same
> level?

*nod*

> Also a local struct inode variable instead of using VFS_I(ip) 4 times
> would be nice.

Will fix.

> Otherwise looks good,
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>

Thanks.

-Dave.

-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list