[PATCH 2/2] xfs: flush both inodes in xfs_swap_extents

Christoph Hellwig hch at infradead.org
Thu Jul 31 12:16:02 CDT 2014


>  int
> +xfs_swap_extent_flush(
> +	struct xfs_inode	*ip)
> +{
> +	int	error;

nipick:  shouldn't the arguments and local variables align to the same
level?

Also a local struct inode variable instead of using VFS_I(ip) 4 times
would be nice.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list