[PATCH] Detect strto* failures based on errno.

Dave Chinner david at fromorbit.com
Tue Jul 15 22:01:32 CDT 2014


On Mon, Jul 14, 2014 at 09:56:59AM +0200, Arkadiusz Miśkiewicz wrote:
> Code was testing for ERANGE errno only in some places. In other places
> it didn't do any errno checking at all.
> 
> Unify strto* result testing by treating any non zero errno as failure.
> 
> Signed-off-by: Arkadiusz Miśkiewicz <arekm at maven.pl>

This patch appears to cause xfs/071 to fail:



     Writing 512 bytes, offset is +0 (direct=false)
    -pwrite64: File too large
    +non-numeric offset argument -- <OFFSET>
     Reading 512 bytes (direct=false)
     read 0/512 bytes at offset <OFFSET>
    ...
    (Run 'diff -u tests/xfs/071.out /home/dave/src/xfstests-dev/results//xfs/071.out.bad'  to see the entire diff)

Can you have a look into this?

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list