[PATCH] xfsprogs/quota: fix NULL pointer dereference in report_f

Eric Sandeen sandeen at sandeen.net
Tue Jul 15 07:54:06 CDT 2014


On 7/15/14, 5:14 AM, Christoph Hellwig wrote:
> On Fri, Jul 11, 2014 at 08:39:45PM -0500, Eric Sandeen wrote:
>>> Signed-off-by: Jie Liu <jeff.liu at oracle.com>
>>
>> Reviewed-by: Eric Sandeen <sandeen at redhat.com>
>>
>> I know hch had grand plans to make this all nicer, but based on Jeff's
>> followup emails, it looks like this is the only spot needed to simply
>> resolve the problems w/ nonexistent paths in quota, and is a small,
>> contained change we can easily make before the next point release.
> 
> Didn't I say I'm fine with putting this in earlier even if I'd prefer
> a grand solution?

Yes, you did, but it never got a formal reviewed-by or got merged, so I bumped it :)


FWIW I did look at the grand solution, and there was .. something that
didn't make sense to me, so I backed off.  Oh, yeah, I wasn't quite
sure what to do with:

add_args_command(init_args_command);
and
init_args_command();

in quota/init.c  

-Eric



> either way, consider this:
> 
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> 



More information about the xfs mailing list