[PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota

Christoph Hellwig hch at infradead.org
Tue Jul 15 05:25:20 CDT 2014


On Tue, Jul 15, 2014 at 05:35:23PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu at oracle.com>
> 
> We are intended to check up uflags against FS_PROJ_QUOTA rather than 
> FS_USER_UQUOTA once more, it looks to me like a typo, but might cause
> the project quota metadata space can not be removed.

This code was introduced by commit
9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc which attempts to fix the
broken quotarm code.  Seems like we need a testcase for this
functionality or just remove it.  Physically removing the quota file
never seems that useful to me to start with..

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list