consequences of XFS_IOC_FSSETXATTR on non-empty file?

Samuel Just sam.just at inktank.com
Sat Jul 12 20:48:52 CDT 2014


Actually, on this ubuntu kernel (3.13.0-24-generic), it doesn't seem
to give an error.  I'll attach my test case for that.  We don't yet
have a way of reproducing the corruption -- the ext_size change in the
osd simply seemed like a promising lead.
-Sam

On Sat, Jul 12, 2014 at 6:26 PM, Dave Chinner <david at fromorbit.com> wrote:
> On Sat, Jul 12, 2014 at 06:16:54PM -0700, Samuel Just wrote:
>> Hi,
>>
>> We are seeing reports of ceph-osd stores on xfs of files with some
>> garbage data (possibly misplaced from data elsewhere in the
>> filesystem).  There was a bug for a while where the ceph-osd process
>> would set a value for fsx_extsize on a non-empty (possibly sparse)
>> file using XFS_IOC_FSSETXATTR.  Could that plausibly result in a file
>> with garbage data?
>
> No, setting an extent size on a non-empty file will simply fail
> with EINVAL.
>
> Do you have any method of reproducing the bad data in files?
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david at fromorbit.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xfs_extsize_test.cc
Type: text/x-c++src
Size: 1641 bytes
Desc: not available
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20140712/0b63d5bf/attachment.cc>


More information about the xfs mailing list