[PATCH] xfs: require 64-bit sector_t
Michael L. Semon
mlsemon35 at gmail.com
Thu Jan 9 12:48:35 CST 2014
On 01/09/2014 10:19 AM, Ben Myers wrote:
> On Mon, Dec 16, 2013 at 04:15:59PM -0600, Ben Myers wrote:
>> Hey Christoph,
>>
>> On Thu, Nov 14, 2013 at 08:46:03AM -0800, Christoph Hellwig wrote:
>>> Trying to support tiny disks only and saving a bit memory might have
>>> made sense on an SGI O2 15 years ago, but is pretty pointless today.
>>>
>>> Remove the rarely tested codepath that uses various smaller in-memory
>>> types to reduce our test matrix and make the codebase a little bit
>>> smaller and less complicated.
>>>
>>>
>>> Signed-off-by: Christoph Hellwig <hch at lst.de>
>>
>> This looks ok to me. I'm not seeing much downside to removing the smaller
>> in-memory types.
>>
>> Reviewed-by: Ben Myers <bpm at sgi.com>
>
> Anyone else have an opinion on this one? I think its 3.14 material and I'd
> like to pull it in.
>
> Thanks,
> Ben
Either way is fine with me. I use CONFIG_LBDAF=n, but it isn't a make-or-break
kernel config option. Most issues I've seen in testing were solved by Jeff
Liu's patches. This part of the test matrix seemed okay, but if Christoph wants
to get rid of it, that's fine. The XFS support matrix is rather brutal...
Thanks!
Michael
More information about the xfs
mailing list