[PATCH 06/10] repair: use a listhead for the dotdot list

Dave Chinner david at fromorbit.com
Wed Feb 26 20:06:24 CST 2014


On Tue, Feb 25, 2014 at 12:03:32PM -0800, Christoph Hellwig wrote:
> On Mon, Feb 24, 2014 at 05:29:25PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner at redhat.com>
> > 
> > Cleanup suggested by Christoph Hellwig - removes another open coded
> > list implementation.
> 
> Looks good.  Question for both the old and new code:  any good reason to
> do the dotdot updates LIFO?  If yes it might be worth adding a comment
> about that fact.

No, it didn't even occur to me that it might matter. I'll change it
back to FIFO.

> Reviewed-by: Christoph Hellwig <hch at lst.de>

Thanks,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list