[PATCH v2] xfstests: test for atime-related mount options

Dave Chinner david at fromorbit.com
Mon Feb 17 19:05:03 CST 2014


On Mon, Feb 17, 2014 at 02:40:45PM -0600, Eric Sandeen wrote:
> On 2/17/14, 2:25 PM, Koen De Wit wrote:
> > Tests the noatime, relatime, strictatime and nodiratime mount options.
> > 
> > There is an extra check for Btrfs to ensure that the access time is
> > never updated on read-only subvolumes. (Regression test for bug fixed
> > with commit 93fd63c2f001ca6797c6b15b696a484b165b4800)
> 
> I think this looks ok.  Only little nit is that _require_relatime
> now implicitly requires scratch, but *shrug* it was Dave's idea.  ;)

There's a _require_scratch call in there, so it's all good. ;)
Thanks Koen!

> Thanks!
> 
> Reviewed-by: Eric Sandeen <sandeen at redhat.com>

And thanks for the reivew, Eric ;)

Cheers,

Dave.

-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list