[PATCH] xfstests: add regression test for btrfs incremental send
Filipe David Manana
fdmanana at gmail.com
Sun Feb 16 19:36:02 CST 2014
On Monday, February 17, 2014, Dave Chinner <david at fromorbit.com> wrote:
> On Mon, Feb 17, 2014 at 12:20:38AM +0000, Filipe David Borba Manana wrote:
> > Test for a btrfs incremental send issue where we end up sending a
> > wrong section of data from a file extent if the corresponding file
> > extent is compressed and the respective file extent item has a non
> > zero data offset.
> >
> > Fixed by the following linux kernel btrfs patch:
> >
> > Btrfs: use right clone root offset for compressed extents
> >
> > Signed-off-by: Filipe David Borba Manana <fdmanana at gmail.com<javascript:;>
> >
> > ---
> >
> > V2: Made the test more reliable. Now it doesn't depend anymore of btrfs'
> > hole punch implementation leaving hole file extent items when we
> punch
> > beyond the file's current size.
> > V3: Filter xfs_io output and make less use of the run_check function, as
> > suggested by Dave Chinner.
>
> Awesome. Thanks for the quick turn around.
>
> > common/rc | 5 +++
> > tests/btrfs/040 | 119
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> > tests/btrfs/040.out | 9 ++++
> > tests/btrfs/group | 1 +
> > 4 files changed, 134 insertions(+)
> > create mode 100755 tests/btrfs/040
> > create mode 100644 tests/btrfs/040.out
> >
> > diff --git a/common/rc b/common/rc
> > index e91568b..27be009 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -2207,6 +2207,11 @@ run_check()
> > "$@" >> $seqres.full 2>&1 || _fail "failed: '$@'"
> > }
> >
> > +_run_btrfs_util_prog()
> > +{
> > + run_check $BTRFS_UTIL_PROG $*
> > +}
>
> Can you do a cleanup of all the other btrfs tests that can use this?
Ok. I just did that for all the test cases not yet merged, as you probably
noticed already.
For the ones already in the repository, I'll see if I can do it soon this
coming week.
Thanks
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david at fromorbit.com <javascript:;>
>
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20140217/8afb6f41/attachment.html>
More information about the xfs
mailing list