[PATCH v2] xfs_db: fix the setting of unaligned directory fields

Mark Tinguely tinguely at sgi.com
Wed Feb 12 15:37:13 CST 2014


On 02/11/14 18:22, Dave Chinner wrote:
> On Tue, Feb 11, 2014 at 08:18:41AM -0600, Mark Tinguely wrote:
>> On 02/10/14 19:31, Dave Chinner wrote:

...

> Hence I'd suggest that "if (bit_field & NBBY) return NULL;" is
> appropriate for hex block format input, and the input should never
> be treated as a host-endian integer...
>
> Cheers,
>
> Dave.

I don't like having the hex block format as an integer input. My change 
would change the result if used as an integer, I just trying to keep 
compatibility with the previous code.

I will gladly leave the hex block input alone and remove the test that 
uses it as an integer.

--Mark.



More information about the xfs mailing list