[PATCH 2/5] fs: Fix WARN_ON in inode_set_mask()
Al Viro
viro at ZenIV.linux.org.uk
Thu Dec 4 08:37:09 CST 2014
On Thu, Dec 04, 2014 at 02:27:36PM +0100, Jan Kara wrote:
> WARN_ON in inode_set_mask() warns if we don't clear all bits we are
> setting instead of reverse - warning when caller requests setting and
> clearing of the same bit.
WTF? 'mask' is "all bits we are asked to modify", 'flags' - "the values to
put into those bits". Have you even looked at the callers, let alone
tested it?
More information about the xfs
mailing list