[PATCH 2/5] fs: Fix WARN_ON in inode_set_mask()
Jan Kara
jack at suse.cz
Thu Dec 4 07:27:36 CST 2014
WARN_ON in inode_set_mask() warns if we don't clear all bits we are
setting instead of reverse - warning when caller requests setting and
clearing of the same bit.
Signed-off-by: Jan Kara <jack at suse.cz>
---
fs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/inode.c b/fs/inode.c
index fcc0886c5824..3490389dc813 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1923,7 +1923,7 @@ void inode_set_flags(struct inode *inode, unsigned int flags,
{
unsigned int old_flags, new_flags;
- WARN_ON_ONCE(flags & ~mask);
+ WARN_ON_ONCE(flags & mask);
do {
old_flags = ACCESS_ONCE(inode->i_flags);
new_flags = (old_flags & ~mask) | flags;
--
1.8.1.4
More information about the xfs
mailing list