[PATCH v2] xfs: lobotomise xfs_trans_read_buf_map()

Christoph Hellwig hch at infradead.org
Wed Dec 3 04:53:41 CST 2014


>  /*
>   * Get and lock the buffer for the caller if it is not already
>   * locked within the given transaction.  If it has not yet been
> @@ -255,46 +248,11 @@ xfs_trans_read_buf_map(
>  	struct xfs_buf		**bpp,
>  	const struct xfs_buf_ops *ops)
>  {
> -	xfs_buf_t		*bp;
> -	xfs_buf_log_item_t	*bip;
> +	struct xfs_buf		*bp = NULL;
> +	struct xfs_buf_log_item	*bip;
>  	int			error;
>  
>  	*bpp = NULL;
> +	/*
> +	 * If we've had a read error, then the contents of the buffer are
> +	 * invalid and shoul dnot be used. To ensure that a followup read tries

			should not

Otherwise looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list