> STATIC void needs the static removed as pointed out by Brian. > - bool read = !!(bp->b_flags & XBF_READ); > + bool read = !!(bp->b_flags & XBF_READ); We don't really need the double negation here. Otherwise this looks reasonable to me.