Is jdm_delete_filehandle part of a public API?
Christoph Hellwig
hch at infradead.org
Fri Aug 1 08:53:05 CDT 2014
On Tue, Jul 29, 2014 at 12:31:43PM -0500, Eric Sandeen wrote:
> I was cleaning up xfsprogs to plug some leaks, and wanted to use
> jdm_delete_filehandle(). I noticed that it has an "hlen" argument which
> is unused.
>
> Can we remove that, or is this part of a public API? It's not in any
> manpage (or even called anywhere in xfsprogs/xfstests/xfsdump/dmapi)
> but it is in a public header...
>
> anyone know?
>
> If needed I guess I can just call it with hlen==0, but that seems odd.
If it's in a public header we shouldn't touch it unless there's a
pressing need.
Talking about libhandle: this one has been a bit bitrotted. Maybe it's
a good time to move everything over to the kernel by handle syscalls
and deprecated it?
More information about the xfs
mailing list